scripts: new backport-create-issue script #21480
Conversation
smithfarm
force-pushed
the
wip-backport-create-issue
branch
2 times, most recently
from
d45d56e
to
8ac959e
Compare
This is a standalone implementation of a script written by Loic Dachary. Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
smithfarm
force-pushed
the
wip-backport-create-issue
branch
from
c3865ee
to
fda5fea
Compare
src/script/backport-create-issue
Outdated
| return None | ||
|
|
||
|
|
||
| args = parse_arguments() |
There was a problem hiding this comment.
might want to guard following statements with
if __name__ == '__main__':it's a useful idiom in python development. it helps when one wants to debug part of this script without running all the main() statements in a wholesale.
| update_relations(r, issue, dry_run) | ||
| logging.info("Processed {} issues with status Pending Backport" | ||
| .format(counter)) | ||
| return None |
There was a problem hiding this comment.
this return value is never used. and a method return nothing actually evaluates to None. so this is not necessary.
There was a problem hiding this comment.
I prefer to make the return value explicit. When I'm re-reading the code, it signals to me that this function is not designed to return anything useful.
There was a problem hiding this comment.
While I support not returning, I'm ok just merging this as is as this should beat copying issues in tracker that many users get wrong anyway
There was a problem hiding this comment.
@theanalyst Thanks! The reasoning for making the return value explicit is (a) it does something useful (remind me that the function is only used for its side effects, not for its return value), and (b) it does no harm. But this is a matter of coding style preference.
| logging.basicConfig(level=logging.DEBUG) | ||
| else: | ||
| logging.basicConfig(level=logging.INFO) | ||
| return None |
There was a problem hiding this comment.
no need to return "None".
Signed-off-by: Nathan Cutler <ncutler@suse.com>
smithfarm
changed the title
This is an initial (and rather careless) standalone implementation of a script written by Loic Dachary. It has been tested manually, and seems to do the job.
The script iterates over all issues in status "Pending Backport" and, where necessary, creates issues in the Backport tracker and "Copied to/from" relations between the backport tracker issue and the parent issue.
I only tagged @ktdreyer and @theanalyst for review, but all reviews are welcome!!!