ceph-volume: allow parallel creates #21489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the create code decides the vg_name "ceph-$cluster_fsid" as the primary vg_name and creates a new name if this already exists. If this code is run N times in parallel, the script will try to create N times the vg with the name "ceph-$cluster_fsid" and it will fail to create the N osds successfully. Creating vgs with names like "ceph-$uuid4" lets our scripts to run without any problems. Signed-off-by: Theofilos Mouratidis <t.mour@cern.ch>
|
@alfredodeza can you review this? |
andrewschoen
approved these changes
Apr 18, 2018
|
jenkins test ceph-volume tox |
|
@thmour would you please push this branch to https://github.com/ceph/ceph-ci so that we can get some repos to test against. Thanks! |
|
@thmour thanks for this PR, I've taken your branch and pushed to ceph-ci.git so that we can get packages, will trigger some functional tests once those repos are ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the create code decides the vg_name "ceph-$cluster_fsid" as
the primary vg_name and creates a new name if this already exists.
If this code is run N times in parallel, the script will try to
create N times the vg with the name "ceph-$cluster_fsid" and it
will fail to create the N osds successfully.
Creating vgs with names like "ceph-$uuid4" lets our scripts to run
in parallel without any problems.
Fixes: http://tracker.ceph.com/issues/23757
Signed-off-by: Theofilos Mouratidis t.mour@cern.ch