Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luminous: common: posix_fallocate on ZFS returns EINVAL #21514

Merged
merged 1 commit into from
May 21, 2018
Merged

luminous: common: posix_fallocate on ZFS returns EINVAL #21514

merged 1 commit into from
May 21, 2018

Conversation

smithfarm
Copy link
Contributor

Backport of #20398

@wjwithagen @smithfarm
common: posix_fallocate on ZFS returns EINVAL
fbccd3b 
But even still it would not work on any COW FS.
So reorganised the code to have a common routine
that in the end will allocate a file on disk if needed

FileStore would not build when there was no HAVE_POSIX_FALLOCATE
other than on Apple. With ceph_posix_fallocate FileStore will also
fallback to manually allocating the required file.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
(cherry picked from commit 1230e69)
@smithfarm smithfarm added this to the luminous milestone Apr 19, 2018
@wjwithagen
Copy link
Contributor

@smithfarm
Building on FreeBSD 12.0 branch: luminous to make sure it is doing what it should do.
Might take some time om my poor simple tester.

@wjwithagen
Copy link
Contributor

@smithfarm
Got another error whilest compiling for something I expect to be a C++17 issue:

/usr/srcs/Ceph/master/ceph/src/common/bounded_key_counter.h:154:14: error: no matching member function for call to 'assign'
      sorted.assign(const_pointer_iterator{counters.cbegin()},
      ~~~~~~~^~~~~~

But this PR is oke.

wjwithagen
wjwithagen approved these changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@wjwithagen wjwithagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuriw
Copy link
Contributor

yuriw commented May 16, 2018

wip-yuri3-testing-2018-05-16-1620-luminous

@yuriw yuriw merged commit 4baed2c into ceph:luminous May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

@wjwithagen wjwithagen wjwithagen approved these changes

Assignees
No one assigned
Labels
common core luminous-batch-1 wip-yuri3-testing
Projects
None yet
Milestone
luminous
5 participants
@smithfarm @wjwithagen @yuriw @tchaikov @theanalyst