mgr/dashboard: rbd: add @AuthRequired to snapshots controller #21517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo Dias <rdias@suse.com>
|
Well, this PR is my main argument to defend that authentication should be required by default, and we should disable it explicitly when we don't want it... |
ricardoasmarques
approved these changes
Apr 19, 2018
|
I tend to agree with @ricardoasmarques here. I'd assume that the majority of the REST API endpoints requires authentication by default and we should rather think about making it possible to add an exception to the rule, if necessary. |
votdev
approved these changes
Apr 19, 2018
|
@ricardoasmarques @LenzGr created http://tracker.ceph.com/issues/23796 to keep track of that. |
|
QA dashboard test cases run successfully although the tests were marked as failed due to an unrelated failure: http://pulpito.ceph.com/rdias-2018-04-19_15:33:17-rados:mgr-wip-rdias-testing-distro-basic-smithi/ |
|
jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ricardo Dias rdias@suse.com