mgr/dashboard: RBD copy, RBD flatten and snapshot clone (frontend) #21526

ricardoasmarques · 2018-04-19T14:15:37Z

This PR will add the frontend implementation for RBD copy, RBD flatten and snapshot clone functionalities.

Signed-off-by: Ricardo Marques rimarques@suse.com

ricardoasmarques · 2018-04-20T07:10:40Z

FYI, I've now pushed a new commit with the "RBD copy" implementation.

dillaman · 2018-04-20T14:38:18Z

...mgr/dashboard/frontend/src/app/ceph/block/rbd-snapshot-list/rbd-snapshot-list.component.html

@@ -33,6 +33,12 @@
            <span *ngIf="selection.first()?.is_protected"><i class="fa fa-fw fa-unlock"></i><span i18n>Unprotect</span></span>
          </a>
        </li>
+        <li role="menuitem"
+            [ngClass]="{'disabled': !selection.hasSingleSelection || selection.first().executing || !selection.first().is_protected}">


Starting w/ Mimic, you do not need to use protected snapshots to clone an image if clone v2 is enabled. It would be based on the rbd_default_clone_format configuration setting:

1: require a protected snapshot
2: do not require a protected snapshot
auto: check the OSD maps' min_compat_client / require_min_compat_client values and if the minimum client is at least Mimic, do not require a protected snapshot.

dillaman · 2018-04-20T14:39:19Z

...mgr/dashboard/frontend/src/app/ceph/block/rbd-snapshot-list/rbd-snapshot-list.component.html

+          <a class="dropdown-item" routerLink="/rbd/clone/{{ poolName }}/{{ rbdName }}/{{ selection.first()?.name }}">
+            <i class="fa fa-fw fa-clone"></i><span i18n>Clone</span>
+          </a>
+        </li>
        <li role="menuitem"


Nit: add support for copying an image snapshot

dillaman · 2018-04-20T14:42:21Z

src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-form/rbd-form.component.ts

+    request.child_pool_name = this.rbdForm.get('pool').value;
+    request.child_image_name = this.rbdForm.get('name').value;
+    request.obj_size = this.formatter.toBytes(this.rbdForm.get('obj_size').value);
+    if (!this.defaultFeaturesFormControl.value) {


Nit: when I cloned an image w/ default features, the clone model didn't have the default features checkbox selected but did have each individual feature selected.

I've now created a new REST API endpoint to get the default features from the "rbd_default_features" config, which allowed me to remove the "Default features" checkbox from the UI.

Default features will now be pre-selected on the creation form, which I believe is an usability improvement.

dillaman · 2018-04-20T14:42:47Z

src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-form/rbd-form.component.ts

+    request.dest_pool_name = this.rbdForm.get('pool').value;
+    request.dest_image_name = this.rbdForm.get('name').value;
+    request.obj_size = this.formatter.toBytes(this.rbdForm.get('obj_size').value);
+    if (!this.defaultFeaturesFormControl.value) {


Nit: same comment here

dillaman · 2018-04-20T14:44:49Z

src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-list/rbd-list.component.html

+        <li role="menuitem"
+            [ngClass]="{'disabled': !selection.hasSingleSelection || selection.first().executing}">
+          <a class="dropdown-item" routerLink="/rbd/copy/{{ selection.first()?.pool_name }}/{{ selection.first()?.name }}"><i class="fa fa-fw fa-copy"></i><span i18n>Copy</span></a>
+        </li>
        <li role="menuitem"
            [ngClass]="{'disabled': !selection.hasSingleSelection || selection.first().executing}">
          <a class="dropdown-item" (click)="deleteRbdModal()"><i class="fa fa-fw fa-trash-o"></i><span i18n>Delete</span></a>


Nit: not related to this PR, but when I attempted to delete a parent image, I correctly received an error alert but the delete modal did not automatically close (it just stuck spinning, forcing me to click cancel).

ricardoasmarques · 2018-04-20T21:43:23Z

I've pushed a new commit with RBD flatten functionality.

votdev · 2018-04-23T14:09:16Z

You need to adapt your controller to the latest changes.
"Module 'dashboard' has failed dependency: type object 'RESTController' has no attribute 'args_from_json'"

ricardoasmarques · 2018-04-23T23:42:30Z

@votdev I've now rebase this branch and removed the usage of args_from_json.

Note that ATM master branch is broken, so you have to apply #21606 to compile ceph with success.

rjfd · 2018-04-24T13:19:26Z

qa/tasks/mgr/dashboard/test_rbd.py

+
+    def test_flatten(self):
+        self.create_snapshot('rbd', 'img1', 'snapf')
+        self._rbd_cmd(['snap', 'protect', 'rbd/img1@snapf'])


I prefer to use our own REST API endpoints to do this, to get better coverage of our own code.
For instance, use: self.update_snapshot('rbd', 'img1', 'snapf', None, True)

rjfd · 2018-04-24T13:20:45Z

qa/tasks/mgr/dashboard/test_rbd.py

+    def test_flatten(self):
+        self.create_snapshot('rbd', 'img1', 'snapf')
+        self._rbd_cmd(['snap', 'protect', 'rbd/img1@snapf'])
+        self._rbd_cmd(['clone', 'rbd/img1@snapf', 'rbd_iscsi/img1_snapf_clone'])


Maybe use: self.clone_image('rbd', 'img1', 'snapf', 'rbd_iscsi', 'img1_snapf_clone')

rjfd · 2018-04-24T13:21:22Z

qa/tasks/mgr/dashboard/test_rbd.py

+        self.assertStatus(200)
+        self.assertIsNone(img['parent'])
+
+        self._rbd_cmd(['snap', 'unprotect', 'rbd/img1@snapf'])


self.update_snapshot('rbd', 'img1', 'snapf', None, False)

rjfd · 2018-04-24T13:22:11Z

qa/tasks/mgr/dashboard/test_rbd.py

+
+    def test_default_features(self):
+        default_features = self._task_post('/api/block/image/default_features')
+        self.assertEquals(default_features, ['deep-flatten', 'exclusive-lock',


assertEquals is deprecated, use assertEqual instead

rjfd · 2018-04-24T13:24:21Z

src/pybind/mgr/dashboard/controllers/rbd.py

+
+        return _rbd_image_call(pool_name, image_name, _flatten)
+
+    @RESTController.collection()


please specify the HTTP method allowed (I guess it should be GET): @RESTController.collection(['GET'])

rjfd · 2018-04-24T13:25:38Z

qa/tasks/mgr/dashboard/test_rbd.py

+        self.assertStatus(204)
+
+    def test_default_features(self):
+        default_features = self._task_post('/api/block/image/default_features')


Why using a POST request to retrieve info? this should be a GET http request.

rjfd · 2018-04-24T15:42:38Z

QA tests were successful: http://pulpito.ceph.com/rdias-2018-04-24_15:10:55-rados:mgr-wip-rdias-testing-distro-basic-smithi/

Signed-off-by: Ricardo Marques <rimarques@suse.com>

Signed-off-by: Ricardo Dias <rdias@suse.com>

Signed-off-by: Ricardo Marques <rimarques@suse.com>

ricardoasmarques · 2018-04-24T16:06:55Z

@dillaman @rjfd I've addressed all your comment, thanks for reviewing.

votdev · 2018-04-25T11:29:50Z

Would like to see the feature that the snapshot name is auto-generated using the current date, e.g. <IMAGENAME>_2018-04-25_13:29:11.

votdev · 2018-04-25T11:34:21Z

The Created column does not display the date in my local date/time format.

votdev · 2018-04-25T11:39:53Z

Would be great if the Name field in the 'Copy|Clone RBD' form will be pre-filled, e.g. using the origin image name and the prefix _(copy|clone) and or the current date to make it unique.

votdev · 2018-04-25T11:41:41Z

If i press the Back button in the clone form i would expect that the previous view showing me the snapshot table is shown again. Currently the image table is displayed without any selected image.

rjfd · 2018-04-25T11:46:15Z

@votdev could you paste the stack trace of that 500 error?

rjfd · 2018-04-25T13:48:59Z

Run QA tests again with the latest change, and every test passed: http://pulpito.ceph.com/rdias-2018-04-25_11:46:51-rados:mgr-wip-rdias-testing-distro-basic-smithi/

ricardoasmarques · 2018-04-25T14:10:23Z

Would like to see the feature that the snapshot name is auto-generated using the current date, e.g. _2018-04-25_13:29:11.

Would be great if the Name field in the 'Copy|Clone RBD' form will be pre-filled, e.g. using the origin image name and the prefix _(copy|clone) and or the current date to make it unique.

I would like to avoid any kind of name auto-generation until we have feedback from someone that uses this features in a production environment. Otherwise we run the risk of suggesting names that do not make sense in real-world usage.

ricardoasmarques · 2018-04-25T14:18:27Z

If i press the Back button in the clone form i would expect that the previous view showing me the snapshot table is shown again. Currently the image table is displayed without any selected image.

I agree that this behavior would be an improvement, but our datatable doesn't support that.

Maybe we should enhance our datatable to reflect the selection and pagination info in the URL, but this is clearly a separate PR IMO.

ricardoasmarques · 2018-04-25T14:24:44Z

The Created column does not display the date in my local date/time format.

Thanks for reporting this, but this table is not part of this PR.

I would say that this is an issue on cdDatePipe that is widely used across the dashboard frontend.

What about reporting an issue on http://tracker.ceph.com/ ?

votdev · 2018-04-25T14:48:30Z

@ricardoasmarques I've created a bug report for the cdDatePipe.

ricardoasmarques added feature dashboard labels Apr 19, 2018

ricardoasmarques requested review from votdev and Devp00l April 19, 2018 14:15

dillaman self-requested a review April 19, 2018 14:58

ricardoasmarques requested a review from rjfd April 19, 2018 15:25

LenzGr added this to the mimic milestone Apr 19, 2018

ricardoasmarques force-pushed the wip-rbd-snapshot-clone branch from 62bf6ce to b1ed769 Compare April 19, 2018 17:08

ricardoasmarques changed the title ~~mgr/dashboard: RBD snapshot clone (frontend)~~ mgr/dashboard: RBD snapshot clone and RBD copy (frontend) Apr 20, 2018

ricardoasmarques changed the title ~~mgr/dashboard: RBD snapshot clone and RBD copy (frontend)~~ mgr/dashboard: RBD copy and snapshot clone (frontend) Apr 20, 2018

dillaman reviewed Apr 20, 2018

View reviewed changes

ricardoasmarques force-pushed the wip-rbd-snapshot-clone branch from c277aed to 68d8a94 Compare April 20, 2018 21:42

ricardoasmarques changed the title ~~mgr/dashboard: RBD copy and snapshot clone (frontend)~~ mgr/dashboard: RBD copy, RBD flatten and snapshot clone (frontend) Apr 20, 2018

ricardoasmarques force-pushed the wip-rbd-snapshot-clone branch from 68d8a94 to 2b5c3fa Compare April 23, 2018 08:56

ricardoasmarques force-pushed the wip-rbd-snapshot-clone branch from 0b2b3e3 to 0def4f0 Compare April 23, 2018 23:38

ricardoasmarques force-pushed the wip-rbd-snapshot-clone branch from 0def4f0 to 5cd040c Compare April 24, 2018 10:24

rjfd added needs-qa wip-rdias-testing labels Apr 24, 2018

rjfd suggested changes Apr 24, 2018

View reviewed changes

ricardoasmarques force-pushed the wip-rbd-snapshot-clone branch from 5cd040c to 650db96 Compare April 24, 2018 15:32

ricardoasmarques and others added 5 commits April 24, 2018 16:50

mgr/dashboard: RBD snapshot clone (frontend)

cc3ffad

Signed-off-by: Ricardo Marques <rimarques@suse.com>

mgr/dashboard: RBD copy (frontend)

ef563c3

Signed-off-by: Ricardo Marques <rimarques@suse.com>

mgr/dashboard: RBD flatten

838c9ce

Signed-off-by: Ricardo Marques <rimarques@suse.com>

mgr/dashboard: Add support for RBD snapshot copy

fa735d5

Signed-off-by: Ricardo Dias <rdias@suse.com>

mgr/dashboard: Add support for RBD snapshot copy (frontend)

3dd7dab

Signed-off-by: Ricardo Marques <rimarques@suse.com>

ricardoasmarques added 2 commits April 24, 2018 16:50

mgr/dashboard: Add RBD default features REST API endpoint

eeb87d3

Signed-off-by: Ricardo Marques <rimarques@suse.com>

mgr/dashboard: Remove RBD "Default Features" checkbox

9f6e889

Signed-off-by: Ricardo Marques <rimarques@suse.com>

ricardoasmarques force-pushed the wip-rbd-snapshot-clone branch from 650db96 to 9f6e889 Compare April 24, 2018 15:50

rjfd approved these changes Apr 25, 2018

View reviewed changes

rjfd removed needs-qa wip-rdias-testing labels Apr 25, 2018

LenzGr merged commit 893857f into ceph:master Apr 26, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mgr/dashboard: RBD copy, RBD flatten and snapshot clone (frontend) #21526

mgr/dashboard: RBD copy, RBD flatten and snapshot clone (frontend) #21526

ricardoasmarques commented Apr 19, 2018 •

edited

ricardoasmarques commented Apr 20, 2018

dillaman Apr 20, 2018

dillaman Apr 20, 2018

dillaman Apr 20, 2018

ricardoasmarques Apr 23, 2018

dillaman Apr 20, 2018

dillaman Apr 20, 2018

ricardoasmarques commented Apr 20, 2018

votdev commented Apr 23, 2018

ricardoasmarques commented Apr 23, 2018

rjfd Apr 24, 2018

rjfd Apr 24, 2018

rjfd Apr 24, 2018

rjfd Apr 24, 2018

rjfd Apr 24, 2018

rjfd Apr 24, 2018

rjfd commented Apr 24, 2018

ricardoasmarques commented Apr 24, 2018

votdev commented Apr 25, 2018

votdev commented Apr 25, 2018

votdev commented Apr 25, 2018 •

edited

votdev commented Apr 25, 2018

rjfd commented Apr 25, 2018

rjfd commented Apr 25, 2018

ricardoasmarques commented Apr 25, 2018

ricardoasmarques commented Apr 25, 2018 •

edited

ricardoasmarques commented Apr 25, 2018

votdev commented Apr 25, 2018


		return _rbd_image_call(pool_name, image_name, _flatten)

		@RESTController.collection()

mgr/dashboard: RBD copy, RBD flatten and snapshot clone (frontend) #21526

mgr/dashboard: RBD copy, RBD flatten and snapshot clone (frontend) #21526

Conversation

ricardoasmarques commented Apr 19, 2018 • edited

ricardoasmarques commented Apr 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ricardoasmarques commented Apr 20, 2018

votdev commented Apr 23, 2018

ricardoasmarques commented Apr 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rjfd commented Apr 24, 2018

ricardoasmarques commented Apr 24, 2018

votdev commented Apr 25, 2018

votdev commented Apr 25, 2018

votdev commented Apr 25, 2018 • edited

votdev commented Apr 25, 2018

rjfd commented Apr 25, 2018

rjfd commented Apr 25, 2018

ricardoasmarques commented Apr 25, 2018

ricardoasmarques commented Apr 25, 2018 • edited

ricardoasmarques commented Apr 25, 2018

votdev commented Apr 25, 2018

ricardoasmarques commented Apr 19, 2018 •

edited

votdev commented Apr 25, 2018 •

edited

ricardoasmarques commented Apr 25, 2018 •

edited