rgw: fix error handling for GET with ?torrent #21576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GET requests with ?torrent should never be treated as a normal GET request. if rgw_torrent_flag wasn't true when the object was uploaded, we'll detect the lack of torrent data when reading from omap conversely, if rgw_torrent_flag was true during upload but disabled afterwards, we can still return the torrent data Fixes: http://tracker.ceph.com/issues/23506 Signed-off-by: Casey Bodley <cbodley@redhat.com>
dang
approved these changes
Apr 23, 2018
|
Future TODO: add tooling during RGW scrub to populate the torrent omap data for old objects and those where rgw_torrent_flag was false. |
robbat2
approved these changes
Apr 23, 2018
|
tested in http://pulpito.ceph.com/cbodley-2018-04-24_16:16:24-rgw-wip-cbodley-testing-distro-basic-smithi/ and reran in http://pulpito.ceph.com/cbodley-2018-04-24_22:46:52-rgw-wip-cbodley-testing-distro-basic-smithi/ with a fix for valgrind leaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET requests with ?torrent should never be treated as a normal GET request. if rgw_torrent_flag wasn't true when the object was uploaded, we'll detect the lack of torrent data when reading from omap
conversely, if rgw_torrent_flag was true during upload but disabled afterwards, we can still return the torrent data
Fixes: http://tracker.ceph.com/issues/23506