osd/PG: perfer async_recovery_targets in reverse order of cost #21578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theoretically peers which have a longer list of objects to recover shall equivalently take a longer time to recover and hence have a bigger chance to block client ops. Also, to minimize the risk of data loss, we want to bring those broken (inconsistent) peers back to normal as soon as possible. Putting them into the async_recovery_targets queue, however, did quite the oppsite. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
jdurgin
approved these changes
Apr 21, 2018
|
@tchaikov Thanks! |
xiexingguo
added a commit
to xiexingguo/ceph
that referenced
this pull request
Apr 23, 2018
This is a follow-up fix of ceph#21578, in which I forget that erasure-coded-pools share the same logic when determining the async_recovery_targets.. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
added a commit
to ceph/ceph-ci
that referenced
this pull request
Jul 25, 2018
This is a follow-up fix of ceph/ceph#21578, in which I forget that erasure-coded-pools share the same logic when determining the async_recovery_targets.. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn> (cherry picked from commit 441876f)
xiexingguo
added a commit
to ceph/ceph-ci
that referenced
this pull request
Jan 26, 2019
This is a follow-up fix of ceph/ceph#21578, in which I forget that erasure-coded-pools share the same logic when determining the async_recovery_targets.. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn> (cherry picked from commit 441876f)
xiexingguo
added a commit
to ceph/ceph-ci
that referenced
this pull request
Jan 30, 2019
This is a follow-up fix of ceph/ceph#21578, in which I forget that erasure-coded-pools share the same logic when determining the async_recovery_targets.. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn> (cherry picked from commit 441876f)
xiexingguo
added a commit
to ceph/ceph-ci
that referenced
this pull request
Apr 26, 2019
This is a follow-up fix of ceph/ceph#21578, in which I forget that erasure-coded-pools share the same logic when determining the async_recovery_targets.. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn> (cherry picked from commit 441876f)
xiexingguo
added a commit
to ceph/ceph-ci
that referenced
this pull request
Nov 2, 2019
This is a follow-up fix of ceph/ceph#21578, in which I forget that erasure-coded-pools share the same logic when determining the async_recovery_targets.. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn> (cherry picked from commit 441876f)
xiexingguo
added a commit
to ceph/ceph-ci
that referenced
this pull request
Nov 7, 2019
This is a follow-up fix of ceph/ceph#21578, in which I forget that erasure-coded-pools share the same logic when determining the async_recovery_targets.. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn> (cherry picked from commit 441876f)
xiexingguo
added a commit
to ceph/ceph-ci
that referenced
this pull request
Feb 15, 2020
This is a follow-up fix of ceph/ceph#21578, in which I forget that erasure-coded-pools share the same logic when determining the async_recovery_targets.. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn> (cherry picked from commit 441876f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theoretically peers which have a longer list of objects to recover
shall equivalently take a longer time to recover and hence have a
bigger chance to block client ops.
Also, to minimize the risk of data loss, we want to bring those broken
(inconsistent) peers back to normal as soon as possible. Putting them
into the async_recovery_targets queue, however, did quite the oppsite.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn