Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: Fix infinite call for bi list when resharding a bucket #21584

Merged
merged 1 commit into from Apr 26, 2018

Conversation

oritwas
Copy link
Member

@oritwas oritwas commented Apr 22, 2018

Copy link
Member

@yehudasa yehudasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oritwas see my comments

/* we are skipping the rest of the entries */
if (pmore) {
*pmore = false;
}
return count;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oritwas missing another case in each of list_instance_entries() and list_olh_entries()

@oritwas oritwas force-pushed the wip-rgw-resharding-versioning branch from 5797f0a to 670e2c5 Compare April 22, 2018 12:51
@oritwas
Copy link
Member Author

oritwas commented Apr 22, 2018

@yehudasa , added thanks. The resharding failed on the listing of plain entries.
I am adding a unit test for bi_list in a separate pr as I want to merge this one asap.

Copy link
Member

@yehudasa yehudasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liewegas liewegas changed the title Fix infinite call for bi list when resharding a bucket rgw: Fix infinite call for bi list when resharding a bucket Apr 23, 2018
@liewegas liewegas added this to the mimic milestone Apr 23, 2018
@yuriw
Copy link
Contributor

yuriw commented Apr 25, 2018

wip-yuri3-testing

@oritwas oritwas merged commit ff98185 into ceph:master Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants