mgr/dashboard: Fix data race and use-before-assignment #21590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The race happes, if a task raises an exception very early. Then, `self.getter_thread.event` fails as `getter_thread` is already `None` Also fix use-before-assignment, as `t0` and `t1` are only defined, if no exception was raised. Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The race happens, if a task raises an exception very early.
Then,
self.getter_thread.eventfails asgetter_threadisalready
NoneAlso fix use-before-assignment, as
t0andt1are only defined,if no exception was raised.
Found-by and required for #21066 . See also #21066/tools.py Line 127
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com