mgr/dashboard: Load the datatable content on component initialization #21595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialized. Signed-off-by: Volker Theile <vtheile@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
autoReloadis disabled the data table content is not loaded at least once anymore when the component is initialized. This PR will fix that. Additionally useless code has been removed in the unit test.The
_.isIniteger()test has been introduced to validate the input. If you do not use property binding, e.g.autoReload="false"the autoReload code path is still executed becauseautoReloadcontains"false"(a quoted string) then which is not an expected and correct value here.Signed-off-by: Volker Theile vtheile@suse.com