mgr: reconcile can_run checks and selftest #21607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the influx plugin requires influxdb python module to function, but influxdb mgr plugin is optional for users who don't use influxdb. so it's marked "Suggests" at this moment before we use a more flexible packaging scheme. Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
We execute modules even if can_run=false, so that it is possible to load them for running their selftest hooks. However, we already raise health messages about the fact that they're enabled but can't run, so we don't want to also raise health messages about whatever exceptions they raise from serve() Signed-off-by: John Spray <john.spray@redhat.com>
There are some up-front checks in DaemonServer but it shouldn't assume that its checks are necessarily going to match the choices about how ActivePyModules composes its ::modules member, so let's have some extra checks to avoid risk of crashing mgr on commands sent to unhealthy/unloaded modules. Signed-off-by: John Spray <john.spray@redhat.com>
liewegas
approved these changes
Apr 23, 2018
tchaikov
approved these changes
Apr 24, 2018
|
Tested here: http://pulpito.ceph.com/jspray-2018-04-24_01:06:58-rados:mgr-wip-jcsp-testing-20180423-distro-basic-smithi/ All failures are the MDS_ALL_DOWN log message thing addressed elsewhere |
|
@jcsp probably you could update your local copy of teuthology and rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension to #21594 that reinstates the loading of modules even if they have missing dependencies, so that we can get at their selftest hooks.
The testing on #21594 also showed a crash in ceph-mgr when it was sent commands for a module that was missing from ActivePyModules::modules, so strengthen checks on that path too.
This is passing test_module_selftest on vstart