Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Add 'cd-loading-panel' component #21618

Merged
merged 1 commit into from Apr 25, 2018
Merged

mgr/dashboard: Add 'cd-loading-panel' component #21618

merged 1 commit into from Apr 25, 2018

Conversation

votdev
Copy link
Member

@votdev votdev commented Apr 24, 2018 

<cd-loading-panel i18n
                  *ngIf="editing && loading && !error">
  Loading user data...
</cd-loading-panel>

bildschirmfoto von 2018-04-24 13-27-53

Signed-off-by: Volker Theile vtheile@suse.com

@LenzGr
Copy link
Contributor

LenzGr commented Apr 24, 2018

Just curious - how does this relate to #20744? Does this feature compliment or replace it?

Devp00l
Devp00l approved these changes Apr 24, 2018
View reviewed changes
Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@votdev
Copy link
Member Author

votdev commented Apr 24, 2018

@LenzGr This loading panel is used for forms only. The datatable has a separate progress bar to visualize loading.

ricardoasmarques
ricardoasmarques approved these changes Apr 24, 2018
View reviewed changes
Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@votdev
mgr/dashboard: Introduce 'cd-loading-panel' component
a4bc4ff 
Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev changed the title mgr/dashboard: Introduce 'cd-loading-panel' component mgr/dashboard: Add 'cd-loading-panel' component Apr 25, 2018
@LenzGr LenzGr added this to the mimic milestone Apr 25, 2018
@LenzGr LenzGr merged commit 51866e0 into ceph:master Apr 25, 2018
@votdev votdev deleted the loading_panel branch April 26, 2018 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoasmarques ricardoasmarques ricardoasmarques approved these changes

@Devp00l Devp00l Devp00l approved these changes

@LenzGr LenzGr Awaiting requested review from LenzGr

Assignees
No one assigned
Labels
dashboard feature
Projects
None yet
Milestone
mimic
4 participants
@votdev @LenzGr @ricardoasmarques @Devp00l