mgr/dashboard: pool: fix python3 dict_keys error #21636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,7 @@ class Pool(RESTController): | |||
| @classmethod | |||
| def _serialize_pool(cls, pool, attrs): | |||
| if not attrs or not isinstance(attrs, list): | |||
| attrs = pool.keys() | |||
| attrs = list(pool.keys()) | |||
There was a problem hiding this comment.
So, pool.keys() returns an iterator in Python 3. But attrs is used only once in line 23. I'd think, this line should actually be OK, right?
|
May I say that I really dislike the use of iterators in Python 3? They introduced a ton of unnecessary bugs this way. |
Signed-off-by: Ricardo Dias <rdias@suse.com>
rjfd
force-pushed
the
wip-dashboard-fix-pool-py3
branch
from
6ec4f9b
to
f866072
Compare
|
@sebastian-philipp addressed your comment, and pushed changes. |
votdev
approved these changes
Apr 25, 2018
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value returned by
dict.keys()in python 3 is not of typelistand is not JSON serializable.Therefore we need to convert the result to a list.
Signed-off-by: Ricardo Dias rdias@suse.com