rgw: cloud sync fixes #21648
Merged
rgw: cloud sync fixes #21648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yehudasa
commented
Apr 25, 2018
yehudasa
commented
- aws compatibility fixes (header was sent twice)
- fix busy loop when dealing with asymmetric splice (writes slower than reads)
- fix splice handling of remote end shutdown in middle of operation
- cloud sync, when uploading using multipart upload, set attributes on the multipart create operation (and related refactoring)
- cancel http requests used in splice when deleting cr(f)s (fixes a crash)
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Just send a notification to the writer once we passed a threshold. With a slow writer we'd wake it up continuously while it's waiting for the data to flush. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Some cleanup around the rest client, and fix cloud sync code to send the meta attributes to the remote endpoint. Earlier we didn't do it correctly when dealing with sync that uses multipart upload. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Beside fixing a leak, this also cancels the pending request and any future callback (that would crash). Updated the interface to allow explicit request cancellation. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
cbodley
approved these changes
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.