Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: tagging field support nested search #21663

Closed
wants to merge 1 commit into from

Conversation

tianshan
Copy link
Contributor

add mapping for tagging field

fixes: http://tracker.ceph.com/issues/23882

Signed-off-by: Tianshan Qu tianshan@xsky.com

add mapping for tagging field

fixes: http://tracker.ceph.com/issues/23882

Signed-off-by: Tianshan Qu <tianshan@xsky.com>
@tianshan
Copy link
Contributor Author

I think custom type use "key" is better instead of "name" , if so, I will just modify dump_custom

@stale
Copy link

stale bot commented Oct 18, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Oct 18, 2018
@theanalyst
Copy link
Member

I guess text/string still makes sense here, keyword expects exact matches, not sure whether that is strictly necessary for tagging (may be for tagging keys?)

@stale stale bot removed the stale label Oct 18, 2018
@tianshan
Copy link
Contributor Author

@theanalyst no, without nested type, we can not match one tag key from the tagging group

@stale
Copy link

stale bot commented Dec 30, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Dec 30, 2018
@theanalyst
Copy link
Member

nested type is ok; was just debating on keyword type, but looks good as is.

@stale stale bot removed the stale label Jan 2, 2019
@stale
Copy link

stale bot commented Mar 3, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Mar 3, 2019
@stale
Copy link

stale bot commented Jun 1, 2019

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@stale stale bot closed this Jun 1, 2019
@ZVampirEM77
Copy link
Contributor

@theanalyst ping

@ZVampirEM77
Copy link
Contributor

I think the accuracy of metadata searching will be improved if we modify the tagging field to nested type.

@xiexingguo xiexingguo reopened this Jun 4, 2019
@stale stale bot removed the stale label Jun 4, 2019
@stale
Copy link

stale bot commented Aug 3, 2019

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Aug 3, 2019
@stale
Copy link

stale bot commented Nov 1, 2019

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@stale stale bot closed this Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants