osd/PrimaryLogPG: clear data digest on WRITEFULL if skip_data_digest #21676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we detect we are on bluestore and should skip the data digest, we need to clear any old digest on WRITEFULL. This aligns us with the WRITE behavior, which is also either an update or a clear (but never neither!). Fixes: https://tracker.ceph.com/issues/23871 Signed-off-by: Sage Weil <sage@redhat.com>
|
appears to fix the problem. doing another combined upgrade run with all of the upgrade fixes to be sure! |
jdurgin
approved these changes
Apr 26, 2018
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we detect we are on bluestore and should skip the data digest, we
need to clear any old digest on WRITEFULL. This aligns us with the
WRITE behavior, which is also either an update or a clear (but never
neither!).
Fixes: https://tracker.ceph.com/issues/23871
Signed-off-by: Sage Weil sage@redhat.com