Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Clean up Pylint warnings #21694

Merged
merged 1 commit into from May 3, 2018

Conversation

sebastian-philipp
Copy link
Contributor

  • Enabled warnings that actually make sense
  • Enabled fixme as we only have two left.
  • Removed disable statements that use warning-ids
  • Removed disable statements that are no longer needed

Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com

* Enabled warnings that actually make sense
* Enabled `fixme` as we only have two left.
* Removed disable statements that use warning-ids
* Removed disable statements that are no longer needed

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@LenzGr
Copy link
Contributor

LenzGr commented May 2, 2018

How do these fixes relate to the two commits that were applied by @jcsp in the past days?

5596f48
1e768b3

@sebastian-philipp
Copy link
Contributor Author

@LenzGr they are unrelated.

@LenzGr LenzGr added this to the mimic milestone May 2, 2018
@LenzGr LenzGr merged commit 1a385a3 into ceph:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants