New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbd-mirror: additional thrasher testing #21697
Conversation
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
…iority Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rm -f ${rmt_export} ${loc_export} | ||
rbd --cluster ${CLUSTER2} -p ${pool} export ${image}@${snap_name} ${rmt_export} | ||
rbd --cluster ${CLUSTER1} -p ${pool} export ${image}@${snap_name} ${loc_export} | ||
cmp ${rmt_export} ${loc_export} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dillaman You could do something like this:
rmt_md5sum=`rbd ... export image - | md5sum`
And just compare check sums. It looks like less code and probably a little faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was keeping it consistent w/ https://github.com/ceph/ceph/pull/21697/files/1d5b146cfa6c72f02860f15d1ec330ff97ce0848..de4587012d2d0d35f9d201550d58ffc2faeff27b#diff-1d6828c5e08d9d9d1f6dea4aa3430afaR876. Plus cmp
will at least say the offset of the first delta byte.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dillaman I don't see it is tagged for mimic. Should I wait with the merge?
@trociny It's for mimic |
No description provided.