Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Enable object rendering in KV-table #21701

Merged
merged 1 commit into from May 2, 2018

Conversation

Projects
None yet
4 participants
@Devp00l
Copy link
Contributor

commented Apr 27, 2018

Now it's possible to render objects as values in our key-value table.

Signed-off-by: Stephan Müller smueller@suse.com

@Devp00l Devp00l added the dashboard label Apr 27, 2018

@Devp00l Devp00l requested review from votdev and ricardoasmarques Apr 27, 2018

this.tableData = this.makePairs(this.data);
}

makePairs(data: any) {

This comment has been minimized.

Copy link
@votdev

votdev Apr 30, 2018

Contributor

Consider to make this method private.

return this.postProcessing(temp);
}

makePairsFromArray(data: any[]) {

This comment has been minimized.

Copy link
@votdev

votdev Apr 30, 2018

Contributor

Consider to make this method private.

return temp;
}

makePairsFromObject(data: object) {

This comment has been minimized.

Copy link
@votdev

votdev Apr 30, 2018

Contributor

Consider to make this method private.

}));
}

postProcessing(data: any[]) {

This comment has been minimized.

Copy link
@votdev

votdev Apr 30, 2018

Contributor

Please add a method description about what it is doing and why.

This comment has been minimized.

Copy link
@Devp00l

Devp00l May 2, 2018

Author Contributor

I've renamed it to make clear what it does

}));
}

postProcessing(data: any[]) {

This comment has been minimized.

Copy link
@votdev

votdev Apr 30, 2018

Contributor

Consider to make this method private.

return temp;
}

convertValue(v: any) {

This comment has been minimized.

Copy link
@votdev

votdev Apr 30, 2018

Contributor

Consider to make this method private.

This comment has been minimized.

Copy link
@Devp00l

Devp00l May 2, 2018

Author Contributor

I will rename them with an underscore instead so that they are still testable.

@ricardoasmarques
Copy link
Member

left a comment

lgtm

mgr/dashboard: Enable object rendering in KV-table
Now it's possible to render objects as values in our key-value table.

Signed-off-by: Stephan Müller <smueller@suse.com>

@Devp00l Devp00l force-pushed the Devp00l:wip-kv-table-render-object branch from 968b8fe to 98fc5f9 May 2, 2018

@Devp00l

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2018

@votdev I've addressed all your comments

@votdev

votdev approved these changes May 2, 2018

@LenzGr

This comment has been minimized.

Copy link
Contributor

commented May 2, 2018

retest this please

@LenzGr LenzGr merged commit c608185 into ceph:master May 2, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.