mgr/dashboard: Enable object rendering in KV-table #21701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
votdev
requested changes
Apr 30, 2018
| this.tableData = this.makePairs(this.data); | ||
| } | ||
|
|
||
| makePairs(data: any) { |
There was a problem hiding this comment.
Consider to make this method private.
| return this.postProcessing(temp); | ||
| } | ||
|
|
||
| makePairsFromArray(data: any[]) { |
There was a problem hiding this comment.
Consider to make this method private.
| return temp; | ||
| } | ||
|
|
||
| makePairsFromObject(data: object) { |
There was a problem hiding this comment.
Consider to make this method private.
| })); | ||
| } | ||
|
|
||
| postProcessing(data: any[]) { |
There was a problem hiding this comment.
Please add a method description about what it is doing and why.
There was a problem hiding this comment.
I've renamed it to make clear what it does
| })); | ||
| } | ||
|
|
||
| postProcessing(data: any[]) { |
There was a problem hiding this comment.
Consider to make this method private.
| return temp; | ||
| } | ||
|
|
||
| convertValue(v: any) { |
There was a problem hiding this comment.
Consider to make this method private.
There was a problem hiding this comment.
I will rename them with an underscore instead so that they are still testable.
Now it's possible to render objects as values in our key-value table. Signed-off-by: Stephan Müller <smueller@suse.com>
Devp00l
force-pushed
the
wip-kv-table-render-object
branch
from
968b8fe
to
98fc5f9
Compare
|
@votdev I've addressed all your comments |
votdev
approved these changes
May 2, 2018
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's possible to render objects as values in our key-value table.
Signed-off-by: Stephan Müller smueller@suse.com