Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: release lock executing deep copy progress callback #21727

Merged
merged 1 commit into from May 1, 2018

Conversation

Projects
None yet
2 participants
@trociny
Copy link
Contributor

commented Apr 29, 2018

Fixes: http://tracker.ceph.com/issues/23929
Signed-off-by: Mykola Golub mgolub@suse.com

@trociny trociny added this to the mimic milestone Apr 29, 2018

@dillaman
Copy link
Contributor

left a comment

lgtm

@dillaman

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2018

retest this please

@dillaman

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2018

suspicious that the ARM64 build failed on the TestMockDeepCopyImageCopyRequest.Cancel_Inflight_Sync test

https://jenkins.ceph.com/job/ceph-pull-requests-arm64/16643/console

@trociny trociny force-pushed the trociny:wip-23929 branch from 758ece4 to 93b9eb7 Apr 30, 2018

@trociny

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2018

@dillaman Thanks. I was able to reproduce repeating the test in loop. It raced on complete. Hopefully it is fixed now.

@dillaman dillaman merged commit ff82e16 into ceph:master May 1, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@trociny trociny deleted the trociny:wip-23929 branch May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.