osd: fix _process handling for pg vs slot race #21745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/a/sage-2018-04-30_00:12:46-rados-wip-sage3-testing-2018-04-29-1658-distro-basic-smithi/2453627 |
We could see the slot with a different PG than we expected if the old PG was removed and a new one was instantiated in its place. We can't just pick up the new PG pointer, however, since it isn't locked. Fix by retrying with the slot's new pg (possibly null!). Move this check below the other cases so that we know we are otherwise consistent with the slot, since the next pass around we might get pg==null and skip the to_process.empty() and requeue_seq checks entirely. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-pg-removal-race
branch
from
a7aac76
to
7dbcc77
Compare
|
(failures unrelated to this pr) |
|
I don't think I understand. The commit message says to bail out, but we're retrying in the code, and I don't see a check that will cause it to bail on that retry that wouldn't have been invoked the first time around. |
|
The commit was updated but hte PR description wasn't :) |
gregsfortytwo
approved these changes
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.