Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/OSDMonitor: set FLAG_SELFMANAGED_SNAPS on cephfs snap removal #21756

Merged
merged 2 commits into from May 2, 2018

Conversation

Projects
None yet
4 participants
@liewegas
Copy link
Member

commented May 1, 2018

mon/OSDMonitor: dump osdmaps if crc doesn't match
Dump both the json and hexdump at debug level 20.

Hunting http://tracker.ceph.com/issues/23949

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas added this to the mimic milestone May 1, 2018

@batrick batrick requested a review from ukernel May 1, 2018

mon/OSDMonitor: set FLAG_SELFMANAGED_SNAPS on cephfs snap removal
CephFS uses a different path to remove selfmanaged snaps than librados,
so while the librados path goes through pg_pool_t::remove_unmanaged_snap(),
we open code the snap addition to the pool's removed_snaps here.  If we
don't set FLAG_SELFMANAGED_SNAPS at that time, we will implicitly set it
during decode and get a CRC mismatch.

Fix by explicitly setting FLAG_SELFMANAGED_SNAPS flag here.

Fixes: http://tracker.ceph.com/issues/23949
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas force-pushed the liewegas:wip-23949 branch from 46ef558 to 1124839 May 1, 2018

@batrick

This comment has been minimized.

Copy link
Member

commented May 1, 2018

@ukernel

ukernel approved these changes May 2, 2018

@tchaikov tchaikov merged commit 65a74d4 into ceph:master May 2, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.