mon/OSDMonitor: set FLAG_SELFMANAGED_SNAPS on cephfs snap removal #21756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dump both the json and hexdump at debug level 20. Hunting http://tracker.ceph.com/issues/23949 Signed-off-by: Sage Weil <sage@redhat.com>
CephFS uses a different path to remove selfmanaged snaps than librados, so while the librados path goes through pg_pool_t::remove_unmanaged_snap(), we open code the snap addition to the pool's removed_snaps here. If we don't set FLAG_SELFMANAGED_SNAPS at that time, we will implicitly set it during decode and get a CRC mismatch. Fix by explicitly setting FLAG_SELFMANAGED_SNAPS flag here. Fixes: http://tracker.ceph.com/issues/23949 Signed-off-by: Sage Weil <sage@redhat.com>
ukernel
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/23949