mds: properly reconnect client caps after loading inodes #21769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit e43c02d "mds: filter out blacklisted clients when importing caps" makes MDCache::process_imported_caps() ignore clients that are not in MDCache::rejoin_imported_session_map. The map does not contain clients from which mds has received reconnect messages. This causes some client caps (corresponding inodes were not in cache when mds was in reconnect state) to get dropped. Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
batrick
approved these changes
May 3, 2018
|
Note to self: cherry-pick to mimic. |
|
Probably causes: http://tracker.ceph.com/issues/21777#note-7 |
|
this patch reveals the bug, |
batrick
added a commit
that referenced
this pull request
May 11, 2018
* refs/pull/21769/head: mds: properly reconnect client caps after loading inodes Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e43c02d "mds: filter out blacklisted clients when importing
caps" makes MDCache::process_imported_caps() ignore clients that are
not in MDCache::rejoin_imported_session_map. The map does not contain
clients from which mds has received reconnect messages. This causes
some client caps (corresponding inodes were not in cache when mds was
in reconnect state) to get dropped.
Signed-off-by: "Yan, Zheng" zyan@redhat.com