Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: fix bug which cause can't erase OSDShardPGSlot. #21771

Merged
merged 1 commit into from May 3, 2018

Conversation

Projects
None yet
5 participants
@majianpeng
Copy link
Member

commented May 2, 2018

Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com

osd: fix bug which cause can't erase OSDShardPGSlot.
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
}
if (slot->waiting.empty() &&

This comment has been minimized.

Copy link
@tchaikov

tchaikov May 2, 2018

Contributor

why? slot->waiting is updated in the if block above. so it is intuitive to check for empty in that if block also.

This comment has been minimized.

Copy link
@majianpeng

majianpeng May 2, 2018

Author Member

slot only erase if !slot->waiting.empty(). in normal delete pg, slot->waiting is empty. So it can't erase .

@dillaman dillaman added the core label May 2, 2018

@tchaikov tchaikov added the bug fix label May 2, 2018

@tchaikov tchaikov requested a review from jdurgin May 2, 2018

@tchaikov tchaikov added the needs-qa label May 2, 2018

@tchaikov tchaikov added this to the mimic milestone May 2, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 2, 2018

@liewegas liewegas changed the base branch from master to mimic May 3, 2018

@yuriw yuriw merged commit 64448b6 into ceph:mimic May 3, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.