mgr/influx: Only split string on first occurence of dot (.) #21795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks when going from Luminous 12.2.4 to .5 If this merges I'll make a larger backport PR for the Influx module as it needs some more fixes in Luminous. |
jcsp
approved these changes
May 3, 2018
|
@wido would you mind also creating a redmine ticket + adding a Fixes: here so that we have a place to track the backport? |
tchaikov
approved these changes
May 3, 2018
Service names are not always osd.X or mon.X, they might be rgw.radosgw.rgw1 This would lead to: Unhandled exception from module 'influx' while running on mgr.mon01: too many values to unpack Only split on the first dot as the rest is the service name Fixes: http://tracker.ceph.com/issues/23996 Signed-off-by: Wido den Hollander <wido@42on.com>
|
Done, added @jcsp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service names are not always osd.X or mon.X, they might be
rgw.radosgw.rgw1
This would lead to:
Unhandled exception from module 'influx' while running on mgr.mon01: too many values to unpack
Only split on the first dot as the rest is the service name
Signed-off-by: Wido den Hollander wido@42on.com