Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/dashboard: Refactor RGW backend #21855

Merged
merged 1 commit into from May 9, 2018

Conversation

Projects
None yet
3 participants
@votdev
Copy link
Contributor

commented May 7, 2018

  • Do some polishing in the docs.
  • Refactor RgwClient::is_service_online() method. The system is considered as online if the response structure is valid. The response content itself is not validated in this case.
  • Relocate NoCredentialsException and derive it from RequestException.

Cherry picked from commit ad997b5.

Signed-off-by: Volker Theile vtheile@suse.com

@s0nea

This comment has been minimized.

Copy link
Member

commented May 8, 2018

Backport of #21784

@s0nea s0nea added this to the mimic milestone May 8, 2018

@votdev votdev changed the title mgr/dashboard: Refactor RGW backend mimic: mgr/dashboard: Refactor RGW backend May 8, 2018

@votdev votdev added bug fix and removed backport labels May 8, 2018

@sebastian-philipp
Copy link
Member

left a comment

lgtm

@s0nea

This comment has been minimized.

@s0nea

s0nea approved these changes May 9, 2018

mgr/dashboard: Refactor RGW backend
- Do some polishing in the docs.
- Refactor RgwClient::is_service_online() method. The system is considered as online if the response structure is valid. The response content itself is not validated in this case.
- Relocate NoCredentialsException and derive it from RequestException.

Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit ad997b5)

@votdev votdev force-pushed the votdev:fix_rgw_backend_mimic branch from 62b6c02 to 0127606 May 9, 2018

@s0nea s0nea merged commit fdda187 into ceph:mimic May 9, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@votdev votdev deleted the votdev:fix_rgw_backend_mimic branch May 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.