Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/dashboard: Refactor RGW backend #21855

Merged
merged 1 commit into from May 9, 2018

Conversation

votdev
Copy link
Member

@votdev votdev commented May 7, 2018

  • Do some polishing in the docs.
  • Refactor RgwClient::is_service_online() method. The system is considered as online if the response structure is valid. The response content itself is not validated in this case.
  • Relocate NoCredentialsException and derive it from RequestException.

Cherry picked from commit ad997b5.

Signed-off-by: Volker Theile vtheile@suse.com

@s0nea
Copy link
Member

s0nea commented May 8, 2018

Backport of #21784

@s0nea s0nea added this to the mimic milestone May 8, 2018
@votdev votdev changed the title mgr/dashboard: Refactor RGW backend mimic: mgr/dashboard: Refactor RGW backend May 8, 2018
@votdev votdev added bug-fix and removed backport labels May 8, 2018
Copy link
Contributor

@sebastian-philipp sebastian-philipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@s0nea
Copy link
Member

s0nea commented May 9, 2018

- Do some polishing in the docs.
- Refactor RgwClient::is_service_online() method. The system is considered as online if the response structure is valid. The response content itself is not validated in this case.
- Relocate NoCredentialsException and derive it from RequestException.

Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit ad997b5)
@s0nea s0nea merged commit fdda187 into ceph:mimic May 9, 2018
@votdev votdev deleted the fix_rgw_backend_mimic branch May 11, 2018 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants