Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librados: fix potential race condition if notify immediately fails #21859

Merged
merged 1 commit into from May 9, 2018

Conversation

Projects
None yet
2 participants
@dillaman
Copy link
Contributor

commented May 7, 2018

Fixes: http://tracker.ceph.com/issues/23966
Signed-off-by: Jason Dillaman dillaman@redhat.com

@dillaman dillaman added this to the mimic milestone May 7, 2018

@dillaman dillaman requested a review from tchaikov May 7, 2018

@@ -1828,7 +1828,6 @@ int librados::IoCtxImpl::notify(const object_t& oid, bufferlist& bl,
Context *notify_finish = new C_notify_Finish(client->cct, &notify_finish_cond,
objecter, linger_op, preply_bl,
preply_buf, preply_buf_len);
(void) notify_finish;

This comment has been minimized.

Copy link
@tchaikov

tchaikov May 8, 2018

Contributor

@dillaman we might want to keep this to silence the warnings, but probably we could use the maybe_unused attribute specifier:

[[maybe_unused]] auto notify_finish = ...

@dillaman dillaman force-pushed the dillaman:wip-23966-mimic branch from a74e888 to cc06fba May 8, 2018

@tchaikov tchaikov merged commit 5884eb2 into ceph:mimic May 9, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@dillaman dillaman deleted the dillaman:wip-23966-mimic branch May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.