librados: fix potential race condition if notify immediately fails #21859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
approved these changes
May 8, 2018
tchaikov
reviewed
May 8, 2018
src/librados/IoCtxImpl.cc
Outdated
| @@ -1828,7 +1828,6 @@ int librados::IoCtxImpl::notify(const object_t& oid, bufferlist& bl, | |||
| Context *notify_finish = new C_notify_Finish(client->cct, ¬ify_finish_cond, | |||
| objecter, linger_op, preply_bl, | |||
| preply_buf, preply_buf_len); | |||
| (void) notify_finish; | |||
There was a problem hiding this comment.
@dillaman we might want to keep this to silence the warnings, but probably we could use the maybe_unused attribute specifier:
[[maybe_unused]] auto notify_finish = ...
Fixes: http://tracker.ceph.com/issues/23966 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/23966
Signed-off-by: Jason Dillaman dillaman@redhat.com