mimic: mds: avoid calling rejoin_gather_finish() two times successively #21952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If MDCache::rejoin_gather is empty and MDCache::rejoins_pending is true when MDCache::process_imported_caps() calls maybe_send_pending_rejoins() Both MDCache::rejoin_send_rejoins() and MDCache::process_imported_caps() may call rejoin_gather_finish(). Signed-off-by: "Yan, Zheng" <zyan@redhat.com> Fixes: http://tracker.ceph.com/issues/24047 (cherry picked from commit 0451dae)
Handle two cases: 1. mds receives all cache rejoin messages, then receives mdsmap that says mds cluster enters rejoining state. 2. when opening undef inodes/dirfrags, other mds restarts. Signed-off-by: "Yan, Zheng" <zyan@redhat.com> (cherry picked from commit 0a38a49)
batrick
added a commit
that referenced
this pull request
May 11, 2018
* refs/pull/21952/head: mds: tighten conditions of calling rejoin_gather_finish() mds: avoid calling rejoin_gather_finish() two times successively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/24047