mimic: mds: fix bug that file's max_size doesn't get updated properly #22137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit de3f3d8 make Locker::_do_cap_update() get called before adjusting wanted caps. This is wrong because Locker::_do_cap_update() need uptodate wanted caps to calculate max size. Signed-off-by: "Yan, Zheng" <zyan@redhat.com> Fixes: https://tracker.ceph.com/issues/24111 (cherry picked from commit 4b13d3f)
MDCache::cow_inode() checks "cap->issued() & CEPH_CAP_ANY_WR" to decide if it needs to setup client_need_snapflush for the new snap inode. If cap message flushes dirty caps and releases the same caps, cap->issued() may have no WR caps when MDCache::cow_inode() gets called. The solution is temporarily setting NEEDSNAPFLUSH on Capability::state. Signed-off-by: "Yan, Zheng" <zyan@redhat.com> (cherry picked from commit 9fb61cd)
batrick
added a commit
to batrick/ceph
that referenced
this pull request
May 23, 2018
* refs/pull/22137/head: mds: properly setup client_need_snapflush for snap inode Revert "mds: properly setup need_snapflush for snapped inode"
batrick
approved these changes
May 24, 2018
batrick
added a commit
that referenced
this pull request
May 24, 2018
* refs/pull/22137/head: mds: properly setup client_need_snapflush for snap inode Revert "mds: properly setup need_snapflush for snapped inode" Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/24187