doc: remove duplicate python packages #22203
Conversation
|
@hydro-b could you squash these three commits into a single one? and, could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes . in this case, it would be "doc: ". also, could you add a " |
|
@tchaikov Sure, I have just done all that. Should be fine now. Thanks for the pointers. |
dillaman
changed the title
| @@ -147,6 +145,7 @@ on each machine that will be a iSCSI gateway: | |||
| > cd ceph-iscsi-cli | |||
| > python setup.py install | |||
| > cp usr/lib/systemd/system/rbd-target-api.service /lib/systemd/system | |||
| > cp rbd-target-api.py /usr/bin/rbd-target-api | |||
There was a problem hiding this comment.
The setup.py script is supposed to strip the .py extension from the scripts [1][2]. Is it not working for some reason for you?
[1] https://github.com/ceph/ceph-iscsi-cli/blob/master/setup.py#L45
[2] https://github.com/ceph/ceph-iscsi-config/blob/master/setup.py#L46
There was a problem hiding this comment.
Hmm, it does. But it copies to "/usr/local/bin". The systemd unit file has a ExecStart path of "/usr/bin/rbd-target-api":
ExecStart=/usr/bin/rbd-target-api
I checked the status of the service: reporting it couldn't find the script. I assumed an extra "cp" step was needed, but it turns out the default install path, on Ubuntu 18.04 LTS at least, is /usr/local/bin.
Installing with "python setup.py install --install-scripts=/usr/bin" results in the script being installed in /usr/bin (without the .py extension)
Maybe add the "install --install-scripts=/usr/bin" to ensure where the script will be installed?
hydro-b
force-pushed
the
rbd-docu-fixes
branch
2 times, most recently
from
f9e0e26
to
7f3803f
Compare
dillaman
changed the title
…t installation in path /usr/bin.
Signed-off-by: Stefan Kooman <stefan@kooman.org>
Signed-off-by: Stefan Kooman <stefan@kooman.org>
Small documentation fixes based on my experience of following the manual installation instructions.