mon/OSDMonitor: no_reply on MOSDFailure messages #22259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are ignoring the message, tell the forwarding mon to discard it's state. Fixes: http://tracker.ceph.com/issues/24322 Signed-off-by: Sage Weil <sage@redhat.com>
tchaikov
reviewed
May 29, 2018
src/mon/OSDMonitor.cc
Outdated
| @@ -559,6 +559,7 @@ void OSDMonitor::on_active() | |||
| op->mark_osdmon_event(__func__); | |||
| dispatch(op); | |||
| ls.pop_front(); | |||
| // no need to mon->no_reply since this is a new quorum | |||
There was a problem hiding this comment.
i think the reason we don't need to mon->no_reply() here is that the op is not handled yet. they will be taken care of by PaxosService::dispatch(). we will send no_reply() when actually processing them.
There was a problem hiding this comment.
oh right, i didn't see the dispatch() call there. removing this!
tchaikov
approved these changes
May 29, 2018
Failure ops get attached to the failure report. Once we finally process them, mark them no_reply so that the forwarding mon will know about it. The other paths through prepare_failure() do no_reply on the messages that don't get logged in the failure_info_t::reporters. Fixes: http://tracker.ceph.com/issues/24322 Signed-off-by: Sage Weil <sage@redhat.com>
tchaikov
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/24322