Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/OSDMonitor: no_reply on MOSDFailure messages #22259

Merged
merged 2 commits into from May 29, 2018

Conversation

Projects
None yet
2 participants
@liewegas
Copy link
Member

liewegas commented May 27, 2018

mon/OSDMonitor: no_reply on ignored MOSDFailure
If we are ignoring the message, tell the forwarding mon to discard it's
state.

Fixes: http://tracker.ceph.com/issues/24322
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas

This comment has been minimized.

@liewegas liewegas requested a review from tchaikov May 29, 2018

@@ -559,6 +559,7 @@ void OSDMonitor::on_active()
op->mark_osdmon_event(__func__);
dispatch(op);
ls.pop_front();
// no need to mon->no_reply since this is a new quorum

This comment has been minimized.

Copy link
@tchaikov

tchaikov May 29, 2018

Contributor

i think the reason we don't need to mon->no_reply() here is that the op is not handled yet. they will be taken care of by PaxosService::dispatch(). we will send no_reply() when actually processing them.

This comment has been minimized.

Copy link
@liewegas

liewegas May 29, 2018

Author Member

oh right, i didn't see the dispatch() call there. removing this!

@tchaikov
Copy link
Contributor

tchaikov left a comment

aside from the nit on comment, lgtm.

mon/OSDMonitor: no_reply on MOSDFailure ops we eventually process
Failure ops get attached to the failure report.  Once we finally process
them, mark them no_reply so that the forwarding mon will know about it.
The other paths through prepare_failure() do no_reply on the messages
that don't get logged in the failure_info_t::reporters.

Fixes: http://tracker.ceph.com/issues/24322
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas force-pushed the liewegas:wip-24322 branch from 6c49e10 to f6128e5 May 29, 2018

@tchaikov tchaikov merged commit 7945788 into ceph:master May 29, 2018

4 of 5 checks passed

make check (arm64) running make check
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.