Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Improve max-line-length tslint rule #22279

Merged
merged 1 commit into from May 29, 2018

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented May 28, 2018

Prettier is not breaking strings if they are bigger
then the defined max line length.

With this rule we can make sure lines are not exceeding it,
with the exception of import/export lines.

Signed-off-by: Tiago Melo tmelo@suse.com

Prettier is not breaking strings if they are bigger
then the defined max line length.

With this rule we can make sure lines are not exceeding it,
with the exception of import/export lines.

Signed-off-by: Tiago Melo <tmelo@suse.com>
Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tspmelo tspmelo added the tests label May 28, 2018
@LenzGr LenzGr merged commit 02f0ba9 into ceph:master May 29, 2018
@tspmelo tspmelo deleted the wip-improve-lint-rules branch May 29, 2018 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants