Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: qa: wait longer for osd to flush pg stats #22288

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
2 participants
@tchaikov
Copy link
Contributor

commented May 29, 2018

pg sends pg-stats to mgr every 5 seconds, so we cannot check for the
number of pgs right after creating the pool, at that moment, the number
of pgs could be 0, that's why manger.wait_for_clean() returns right
away, and leaves us with 0 pgs: the pgs serving the pool are still being
created. that's why manager.get_num_active_clean() returns 0
sometimes. so, we should force osd to flush their stats to mgr, and wait
until the pg stats converages.

Fixes: http://tracker.ceph.com/issues/24321
Signed-off-by: Kefu Chai kchai@redhat.com
(cherry picked from commit 3807472)

qa: wait longer for osd to flush pg stats
pg sends pg-stats to mgr every 5 seconds, so we cannot check for the
number of pgs right after creating the pool, at that moment, the number
of pgs could be 0, that's why manger.wait_for_clean() returns right
away, and leaves us with 0 pgs: the pgs serving the pool are still being
created. that's why `manager.get_num_active_clean()` returns `0`
sometimes. so, we should force osd to flush their stats to mgr, and wait
until the pg stats converages.

Fixes: http://tracker.ceph.com/issues/24321
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 3807472)

@tchaikov tchaikov added this to the mimic milestone May 29, 2018

@tchaikov tchaikov requested a review from liewegas May 29, 2018

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2018

retest this please.

@tchaikov tchaikov merged commit d4490c6 into ceph:mimic May 29, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:mimic-24321 branch May 29, 2018

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2018

merging, as mimic is basically the same as master in this area at this moment.

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2018

note to myself, should backport #22485 also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.