mimic: qa: wait longer for osd to flush pg stats #22288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pg sends pg-stats to mgr every 5 seconds, so we cannot check for the number of pgs right after creating the pool, at that moment, the number of pgs could be 0, that's why manger.wait_for_clean() returns right away, and leaves us with 0 pgs: the pgs serving the pool are still being created. that's why `manager.get_num_active_clean()` returns `0` sometimes. so, we should force osd to flush their stats to mgr, and wait until the pg stats converages. Fixes: http://tracker.ceph.com/issues/24321 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 3807472)
|
retest this please. |
liewegas
approved these changes
May 29, 2018
|
merging, as mimic is basically the same as master in this area at this moment. |
|
note to myself, should backport #22485 also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg sends pg-stats to mgr every 5 seconds, so we cannot check for the
number of pgs right after creating the pool, at that moment, the number
of pgs could be 0, that's why manger.wait_for_clean() returns right
away, and leaves us with 0 pgs: the pgs serving the pool are still being
created. that's why
manager.get_num_active_clean()returns0sometimes. so, we should force osd to flush their stats to mgr, and wait
until the pg stats converages.
Fixes: http://tracker.ceph.com/issues/24321
Signed-off-by: Kefu Chai kchai@redhat.com
(cherry picked from commit 3807472)