librbd: fix error path cleanup for opening an image #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the image doesn't exist and caching is enabled, the ObjectCacher was not being shutdown, and the ImageCtx was leaked. The IoCtx could later be closed while the ObjectCacher was still running, resulting in a segfault. Simply use the usual cleanup path in open_image(), which works fine here. Fixes: #8912 Backport: dumpling, firefly Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
liewegas
pushed a commit
that referenced
this pull request
Aug 12, 2014
librbd: fix error path cleanup for opening an image Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the image doesn't exist and caching is enabled, the ObjectCacher was not
being shutdown, and the ImageCtx was leaked. The IoCtx could later be closed
while the ObjectCacher was still running, resulting in a segfault. Simply use
the usual cleanup path in open_image(), which works fine here.
Fixes: #8912
Backport: dumpling, firefly
Signed-off-by: Josh Durgin josh.durgin@inktank.com