rgw: fix throttle_data size not correct #22638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If handle_data get not enough for one write, we will put in pending_data_bl, so the throttle_data will only throttle the last bl. This will affect put and data sync, big object's throttle will useless. make RGWPutObjProcessor_Atomic::handle_data return the actual write_size, throttle_data will get the return size to throttle. Fixes: http://tracker.ceph.com/issues/24594 Signed-off-by: Tianshan Qu <tianshan@xsky.com>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
@tianshan I think the issue this fixes is resolved by the PutObjProcessor refactoring; could you review that and resubmit if there is still an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If handle_data get not enough for one write, we will put in pending_data_bl,
so the throttle_data will only throttle the last bl. This will affect put
and data sync, big object's throttle will useless.
make RGWPutObjProcessor_Atomic::handle_data return the actual write_size,
throttle_data will get the return size to throttle.
Fixes: http://tracker.ceph.com/issues/24594
Signed-off-by: Tianshan Qu tianshan@xsky.com