filestore: fix force_sync race with mount + umount + mount #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider: - mount - sync_entry is doing some work - umount - set force_sync = true - set done = true - sync_entry exits (due to done) - ..but does not set force_sync = false - mount - journal replay starts - sync_entry sees force_sync and does a commit while op_seq == 0 ...crash... Fixes: #9144 Backport: firefly, dumpling Signed-off-by: Sage Weil <sage@redhat.com>
Just to avoid confusion with start_sync(Context*c), which is totally different. Signed-off-by: Sage Weil <sage@redhat.com>
dzafman
pushed a commit
that referenced
this pull request
Aug 21, 2014
filestore: fix force_sync race with mount + umount + mount Reviewed-by: David Zafman <dzafman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.