mimic: ceph-volume: error on commands that need ceph.conf to operate #22747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had been ignoring the failure to load ceph.conf for all subcommands but most of them require that a ceph.conf be present. This changes that so only commands that do not need ceph.conf ignore the failure to find it. Fixes: http://tracker.ceph.com/issues/23941 Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit de8b301)
alfredodeza
approved these changes
Jul 3, 2018
|
this is getting merged although it will later be removed/changed (to avoid conflicts) when #22828 gets backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had been ignoring the failure to load ceph.conf for all subcommands
but most of them require that a ceph.conf be present. This changes that
so only commands that do not need ceph.conf ignore the failure to find
it.
Fixes: http://tracker.ceph.com/issues/23941
Signed-off-by: Andrew Schoen aschoen@redhat.com
(cherry picked from commit de8b301)
backport of #22724