rgw: fix test to identify whether object has tail #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #9226 Reported-by: Sylvain Munaut <s.munaut@whatever-company.com> Backport: firefly We need to identify whether an object is just composed of a head, or also has a tail. Test for pre-firefly objects ("explicit objs") was broken as it was just looking at the number of explicit objs in the manifest. However, this is insufficient, as we might have empty head, and in this case it wouldn't appear, so we need to check whether the sole object is actually pointing at the head. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
liewegas
added a commit
that referenced
this pull request
Aug 26, 2014
rgw: fix test to identify whether object has tail Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9226
Reported-by: Sylvain Munaut s.munaut@whatever-company.com
Backport: firefly
We need to identify whether an object is just composed of a head, or
also has a tail. Test for pre-firefly objects ("explicit objs") was
broken as it was just looking at the number of explicit objs in the
manifest. However, this is insufficient, as we might have empty head,
and in this case it wouldn't appear, so we need to check whether the
sole object is actually pointing at the head.
Signed-off-by: Yehuda Sadeh yehuda@redhat.com