mgr/dashboard: Add package-lock.json #23285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tspmelo
force-pushed
the
wip-package-lock
branch
2 times, most recently
from
57df962
to
aeb40cb
Compare
tspmelo
force-pushed
the
wip-package-lock
branch
from
aeb40cb
to
000e77e
Compare
tspmelo
force-pushed
the
wip-package-lock
branch
2 times, most recently
from
d2ee350
to
e629809
Compare
|
jenkins retest this please |
tspmelo
force-pushed
the
wip-package-lock
branch
2 times, most recently
from
b08f9a6
to
978dfe1
Compare
This will make sure that, at anytime, when someone runs 'npm install' the resulting packages that are installed are allways the same. Signed-off-by: Tiago Melo <tmelo@suse.com>
"npm ci" is the recommended command to install dependencies in a continuous integration system. It will make sure node_modules is empty and that the version in "package-lock.json" match the ones in "package.json" Signed-off-by: Tiago Melo <tmelo@suse.com>
tspmelo
force-pushed
the
wip-package-lock
branch
from
978dfe1
to
b4fc13d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we had another problem in jenkins, caused by an update of a frontend dependency.
More specifically, it was an update of a dependency of a dependency of a dependency.
Using fixed versions in our
package.jsonis not enough to prevent this problemand the only solution is to use and track the
package-lock.jsonfile.