object errors found in be_select_auth_object() aren't logged the same

[dzafman]

No description provided.

[tchaikov]

lgtm in general. just some nit regarding to the error message format.

[tchaikov]

nit, probably we can be more consistent in the error message format? if we have an object level scrub error:

      errorstream << pgid.pgid << " soid " << *k
		  << ": failed to pick suitable object info\n";

and a shard error looks like

<pgid> shard 1: soid 3:ce3f1d6a:::ROBJ1:head size 9 != size 7 from auth oi

in which, the detailed error is started with a ":". and the object id is placed right next to pgid. i think it makes more sense in this context, as it'd easier to identify the error in the line . and if we put the object id next to , will it help the user to sort the output?

[dzafman]

dzafman-2018-08-05_13:25:22-rados-wip-zafman-testing2-distro-basic-smithi
[2869021] FIXED repair_test.yaml
[2868883] Aborted in ceph::buffer::list::iterator_impl::copy()
[2868830] Infrastructure - Package install failure
[2869072] FIXED scrub_test.yaml
[2869024] Infrastructure - Package install failure
[2868913] Infrastructure - Package install failure
[2869033] Aborted in ceph::buffer::list::iterator_impl::copy()
[2868928] LibRadosTwoPoolsPP.ManifestUnset FAILED
[2868854] Infrastructure - Package install failure
[2869079] Infrastructure - Package install failure
[2868938] Infrastructure - Package install failure
[2868791] Hang/timeout in "ceph-helpers.sh:732: destroy_osd: ceph osd purge osd.1 --yes-i-really-mean-it"
[2868879] cluster [ERR] Error -2 reading object
[2869058] FIXED standalone/scrub
[2868968] ClassHandler::ClassMethod::exec() throws exception
[2868992] Infrastructure - Package install failure

FIXED test runs
http://qa-proxy.ceph.com/teuthology/dzafman-2018-08-06_14:27:45-rados-wip-zafman-testing2-distro-basic-smithi/2874733/teuthology.log
http://qa-proxy.ceph.com/teuthology/dzafman-2018-08-06_18:04:49-rados-wip-zafman-testing2-distro-basic-smithi/2874744/teuthology.log
http://qa-proxy.ceph.com/teuthology/dzafman-2018-08-07_09:55:46-rados-wip-zafman-testing2-distro-basic-smithi/2876030/teuthology.log

[dzafman]

@tchaikov I adjusted scrub error messages to be consist. I wasn't sure what you meant, but I always precede the error text with a colon, the shard and soid before it.

[dzafman]

Re-running a rados suite.

[dzafman]

Testing passed
http://pulpito.ceph.com/dzafman-2018-08-16_17:35:08-rados:thrash-wip-zafman-testing4-distro-basic-smithi
2912019 DEAD infrastructure
2911898 Filed http://tracker.ceph.com/issues/26970
2911870 Filed http://tracker.ceph.com/issues/26971
http://pulpito.ceph.com/dzafman-2018-08-17_08:14:49-rados-wip-zafman-testing4-distro-basic-smithi/
2914539 Fix applied here
2914626 Infrastructure
2914664 Filed http://tracker.ceph.com/issues/26972

[dzafman]

retest this please