Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
luminous: osd: PG: add custom_reaction Backfilled and release reservations after bac… #23493
After backfill completes, we directly go to the Recovered state without
Creating a custom_reaction Backfilled, allows us to release reservations,
changed the title from
PG: add custom_reaction Backfilled and release reservations after bac…
luminous: PG: add custom_reaction Backfilled and release reservations after bac…
Aug 9, 2018
@VictorDenisov Please append the following text to the commit message:
Conflicts: src/osd/PG.cc src/osd/PG.h
This signifies to "posterity" that the commit did not cherry-pick cleanly and that manual conflict resolution was undertaken. Bonus points for adding a brief explanation of the conflict and/or what was done to resolve it.
Sep 12, 2018
@VictorDenisov http://pulpito.front.sepia.ceph.com/yuriw-2018-09-22_15:29:46-rados-wip-yuri3-testing-2018-09-20-2224-luminous-distro-basic-smithi/3056890/ seems like a related failure. Can you please take a look?
@VictorDenisov Are you able to view http://qa-proxy.ceph.com/teuthology/yuriw-2018-09-22_15:29:46-rados-wip-yuri3-testing-2018-09-20-2224-luminous-distro-basic-smithi/3056890/teuthology.log? You might need permissions to look at the complete set of logs.
@neha-ojha Is it the error that you are referring to:
I tried it, and it's too difficult ("non-trivial") for me. Maybe it would be better to close this and let @neha-ojha do the backport herself? (Some backports are better left to the developers...)
Alternatively, maybe @neha-ojha could review the cherry-pick and suggest fixes?
This code in master underwent several refactorings which are not in luminous. Basically the code of Backfilled handler is derived from DeferBackfill handler. Though I may have missed the logic behind the refactorings in master. @neha-ojha I would like to try fixing it for several days before giving up, but if it's urgent and you decide to backport yourself please add me to your new PR - I would like to see the correct solution.