osd/ReplicatedPG: avoid dereferencing iterator at end() #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preceding loop could terminate with p == snapset.clones.end(), which we assign to dnewest. We can't dereference the iterator in that case. For example: start_flush ffe627f3/foo/a/test-rados-api-plana05-22080-18/83 v430'42 uv130 blocking snapset b=[b,a]:[a,b]+head start_flush no older clones prev_snapc will be 0, oi.snaps will be [a], p will end up at end(), get assigned to dnewest, and we'll dereference. It's only sometime harmful though because we may still take the right (else) branch... Fixes: #9294 Signed-off-by: Sage Weil <sage@redhat.com>
athanatos
pushed a commit
that referenced
this pull request
Sep 2, 2014
osd/ReplicatedPG: avoid dereferencing iterator at end() Reviewed-by: Samuel Just <sam.just@inktank.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preceding loop could terminate with p == snapset.clones.end(), which we
assign to dnewest. We can't dereference the iterator in that case.
For example:
start_flush ffe627f3/foo/a/test-rados-api-plana05-22080-18/83 v430'42 uv130
blocking
snapset b=[b,a]:[a,b]+head
start_flush no older clones
prev_snapc will be 0, oi.snaps will be [a], p will end up at end(), get
assigned to dnewest, and we'll dereference. It's only sometime harmful
though because we may still take the right (else) branch...
Fixes: #9294 Signed-off-by: Sage Weil sage@redhat.com