osd/ReplicatedPG: do not evict blocked objects #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the object is blocked, that means we are either still promoting it, or we are in the process of doing a blocking flush. In both cases, do not evict it just yet. For the promotion case in particular this can cause a very long op delay because we'll have to restart the promotion, and this can potentially loop indefinitely. For the flush case, flushes are generally only blocking when the user explicitly requests it. In that case, we are not particularly concerned that we may delay the objects eventual eviction as the user is probably controlling that anyway (and even if they aren't, the agent will still try this object again later). Fixes: #9285 Reported-by: Wang, Zhiqiang <zhiqiang.wang@intel.com> Signed-off-by: Sage Weil <sage@redhat.com>
athanatos
pushed a commit
that referenced
this pull request
Sep 2, 2014
osd/ReplicatedPG: do not evict blocked objects Reviewed-by: Samuel Just <sam.just@inktank.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the object is blocked, that means we are either still promoting it, or we
are in the process of doing a blocking flush. In both cases, do not evict it
just yet. For the promotion case in particular this can cause a very long op
delay because we'll have to restart the promotion, and this can potentially
loop indefinitely.
For the flush case, flushes are generally only blocking when the user
explicitly requests it. In that case, we are not particularly concerned that
we may delay the objects eventual eviction as the user is probably
controlling that anyway (and even if they aren't, the agent will still try
this object again later).
Fixes: #9285 Reported-by: Wang, Zhiqiang zhiqiang.wang@intel.com
Signed-off-by: Sage Weil sage@redhat.com