build/ops: rpm: package cephfs-shell for SUSE as well as Fedora #23656
Conversation
|
Is Alternatively (same question asked in a different way), if the right python modules were available in py2 versions, would the current cephfs-shell code run on CentOS 7? |
I'm not sure but I also don't think we should care. py3 is the future thrust upon us so I don't want to spend any effort making this py2 compatible. Keep in mind the shell will only become available broadly in Nautilus. |
| # python3-cmd2 and python3-colorama are not available in RHEL/CentOS, openSUSE | ||
| # or SLES | ||
| %if 0%{?fedora} | ||
| %if 0%{with cephfs_shell} |
|
@batrick OK. Sounds like cephfs-shell should be built only if with_python2 is false. |
|
The (probably rhetorical) question is: do we know yet whether Python 3 will still be "in the future" when Nautilus release rolls around? |
Why? Wouldn't you still install it if |
|
@batrick I see what's needed: whenever cephfs-shell is built, it should be built for py3 unconditionally. |
ceph.spec.in
Outdated
| Requires: python%{python3_pkgversion}-cmd2 | ||
| Requires: python%{python3_pkgversion}-colorama | ||
| Requires: python%{python3_pkgversion}-cephfs | ||
| Requires: python%{_python_buildid}-cmd2 |
There was a problem hiding this comment.
python3_pkgversion is used on purpose.
smithfarm
force-pushed
the
wip-cephfs-shell-fixes
branch
3 times, most recently
from
16cdc19
to
072f1c5
Compare
|
ok, ready now |
ceph.spec.in
Outdated
| @@ -47,14 +47,14 @@ | |||
| %endif | |||
| %endif | |||
| %bcond_with seastar | |||
| %if 0%{?suse_version} >= 1500 | |||
| %if 0%{?fedora} || 0%{?suse_version} >= 1500 # distros where py2 is _optional_ | |||
There was a problem hiding this comment.
error: /tmp/install-deps.1467/ceph.spec:50: bad %if condition
There was a problem hiding this comment.
probably we should put comment in separated lines?
smithfarm
force-pushed
the
wip-cephfs-shell-fixes
branch
from
072f1c5
to
19f1462
Compare
smithfarm
changed the title
6dd06b0 introduced RPM packaging of cephfs-shell This initial packaging was Fedora-only, but colorama and cmd2 *are* packaged for both openSUSE and SLE. Note: there is no py2-compatible version of cephfs-shell. Signed-off-by: Nathan Cutler <ncutler@suse.com>
smithfarm
changed the title
smithfarm
force-pushed
the
wip-cephfs-shell-fixes
branch
from
19f1462
to
e0f7936
Compare
* refs/pull/23656/head: build/ops: rpm: package cephfs-shell for SUSE as well as Fedora Reviewed-by: Kefu Chai <kchai@redhat.com>
6dd06b0 introduced RPM packaging of cephfs-shell
This initial packaging was Fedora-only, but colorama and cmd2 are packaged
for both openSUSE and SLE.
Note: there is no py2-compatible version of cephfs-shell.
Signed-off-by: Nathan Cutler ncutler@suse.com