rgw: log refactoring for data sync #23843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unrelated test failures and valgrind issues |
|
I have created the tracker for this - http://tracker.ceph.com/issues/35830 |
|
@smithfarm not all of it, no. I think @vumrao is only interested in one piece, and i'll split that into a separate pr |
|
i retargeted that tracker issue at #23981 |
cbodley
commented
Sep 7, 2018
src/rgw/rgw_data_sync.cc
Outdated
| if (ret < 0) { | ||
| ldout(sync_env->cct, 0) << "ERROR: a sync operation returned error" << dendl; | ||
| /* we have reported this error */ | ||
| } |
There was a problem hiding this comment.
todo: remove this commit
cbodley
force-pushed
the
wip-rgw-dpp-datasync
branch
from
13c5019
to
c6fec14
Compare
and passes its pointer to RGWRemoteDataLog Signed-off-by: Casey Bodley <cbodley@redhat.com>
and passes its pointer to RGWRemoteBucketLog Signed-off-by: Casey Bodley <cbodley@redhat.com>
the majority of the debug output from this logger is duplicated by the sync tracing output Signed-off-by: Casey Bodley <cbodley@redhat.com>
cbodley
force-pushed
the
wip-rgw-dpp-datasync
branch
from
c6fec14
to
880c348
Compare
|
@cbodley: The second test you just ran didn't pass |
|
@alimaredia i don't think so, no. i see that failure once in a while, i guess there's a race in the test itself but haven't had time to dig into it edit: i opened http://tracker.ceph.com/issues/36034 to track this one |
alimaredia
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the RGWDataSyncDebugLogger, which duplicates most of the logging from the sync trace framework
for logging outside of sync tracing, this implements DoutPrefixProvider for both RGWBucketSyncStatusManager and RGWDataSyncStatusManager and replaces their ldout()s with ldpp_dout()