Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: log refactoring for data sync #23843

Merged
merged 3 commits into from Sep 20, 2018

Conversation

Projects
None yet
4 participants
@cbodley
Copy link
Contributor

commented Aug 31, 2018

removes the RGWDataSyncDebugLogger, which duplicates most of the logging from the sync trace framework

for logging outside of sync tracing, this implements DoutPrefixProvider for both RGWBucketSyncStatusManager and RGWDataSyncStatusManager and replaces their ldout()s with ldpp_dout()

@cbodley cbodley requested a review from alimaredia Aug 31, 2018

@cbodley

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2018

@vumrao

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2018

I have created the tracker for this - http://tracker.ceph.com/issues/35830

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2018

@cbodley @vumrao Is this really needed for luminous, and if so, why?

@cbodley

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2018

@smithfarm not all of it, no. I think @vumrao is only interested in one piece, and i'll split that into a separate pr

@cbodley

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2018

i retargeted that tracker issue at #23981

if (ret < 0) {
ldout(sync_env->cct, 0) << "ERROR: a sync operation returned error" << dendl;
/* we have reported this error */
}

This comment has been minimized.

Copy link
@cbodley

cbodley Sep 7, 2018

Author Contributor

todo: remove this commit

@cbodley cbodley force-pushed the cbodley:wip-rgw-dpp-datasync branch from 13c5019 to c6fec14 Sep 7, 2018

cbodley added some commits Aug 27, 2018

rgw: RGWDataSyncStatusManager implements DoutPrefixProvider
and passes its pointer to RGWRemoteDataLog

Signed-off-by: Casey Bodley <cbodley@redhat.com>
rgw: RGWBucketSyncStatusManager implements DoutPrefixProvider
and passes its pointer to RGWRemoteBucketLog

Signed-off-by: Casey Bodley <cbodley@redhat.com>
rgw: remove RGWSyncDebugLogger
the majority of the debug output from this logger is duplicated by the
sync tracing output

Signed-off-by: Casey Bodley <cbodley@redhat.com>

@cbodley cbodley force-pushed the cbodley:wip-rgw-dpp-datasync branch from c6fec14 to 880c348 Sep 14, 2018

@alimaredia

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2018

@cbodley: The second test you just ran didn't pass test_bucket_index_log_trim. Is that related to the PR?

@cbodley

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2018

@alimaredia i don't think so, no. i see that failure once in a while, i guess there's a race in the test itself but haven't had time to dig into it

edit: i opened http://tracker.ceph.com/issues/36034 to track this one

@cbodley cbodley merged commit 21cb2b4 into ceph:master Sep 20, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@cbodley cbodley deleted the cbodley:wip-rgw-dpp-datasync branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.