osdc/Objecter: fix split vs reconnect race #23850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are reconnecting to an OSD, we may not have a connection established so this feature check is completely unreliable. If there happens to be a split, that could mean we don't resend an op that should have been resent. Instead, we can infer the OSD has the new behavior if require_osd_release is luminous or later. If not, we can look at the per-osd features in the OSDMap. Fixes: http://tracker.ceph.com/issues/22544 Signed-off-by: Sage Weil <sage@redhat.com>
gregsfortytwo
approved these changes
Sep 4, 2018
jdurgin
approved these changes
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are reconnecting to an OSD, we may not have a connection established
so this feature check is completely unreliable. If there happens to be a
split, that could mean we don't resend an op that should have been resent.
Instead, we can infer the OSD has the new behavior if require_osd_release
is luminous or later. If not, we can look at the per-osd features in the
OSDMap.
Fixes: http://tracker.ceph.com/issues/22544
Signed-off-by: Sage Weil sage@redhat.com