adds a navigational menu for docs #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about adding ceph.js to the repository so the documentation is self contained instead of requiring access to a file somewhere on the net ? |
|
@dachary not really, because the HTTP service that is serving the JS and CSS is a generic service for Sphinx docs and it allows us to fix issues (or add new ones) without requiring to change the source of Ceph. |
|
@alfredodeza then it would be useful to add a blurb somewhere on how to maintain/update the ceph.js because I have no clue how it's done ;-) |
|
added 2 commits
September 4, 2014 13:44
Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
alfredodeza
force-pushed
the
wip-8366
branch
from
3aaa469
to
69638df
Compare
|
@jcsp reworded commits. And yes, this is purely asynchronous code so if it fails it just doesn't display. |
johnwilkins
added a commit
that referenced
this pull request
Sep 4, 2014
doc: adds a navigational menu for docs Reviewed-by: John Wilkins <john.wilkins@inktank.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which is basically pulling JS+CSS from the HTTP service shown in the src to the
<head>tag.Links to browsershots showing compatibility in almost every browser (lol Konkeror)
http://browsershots.org/http://ceph.com/docs/wip-8366/radosgw/