mgr/diskprediction: merge initial version of disk failure prediction #24104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This includes #22239 |
liewegas
force-pushed
the
wip-diskprediction
branch
from
e47ce49
to
bf1b765
Compare
|
@hsiang41 This a rebased/squashed version of your PR, plus the COPYING update |
liewegas
added
wip-sage2-testing
wip-sage4-testing
and removed
wip-sage2-testing
labels
jcsp
approved these changes
Sep 17, 2018
jcsp
approved these changes
Sep 17, 2018
|
I see a couple of extra cleanup commits on the original PR that might be from after the squash |
|
Sorry, I fix typo on the document plugin guide. |
This module is written by Rick Chen <rick.chen@prophetstor.com> and provides both a built-in local predictor and a cloud mode that queries a cloud service (provided by ProphetStor) to predict device failures. Signed-off-by: Rick Chen <rick.chen@prophetstor.com> Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-diskprediction
branch
from
bf1b765
to
4abb79f
Compare
|
redid this to capture the latest commits |
liewegas
added a commit
that referenced
this pull request
Sep 18, 2018
* refs/pull/24104/head: mgr/diskprediction: add prototype diskprediction module Reviewed-by: John Spray <john.spray@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a cloud (saas) mode and a local mode. The UX is still a bit awkward, and
we expect to refactor this code into a few different modules, but that will follow
in subsequent pull requests. In the meantime, this module off by default :).