librados: do not write to user buffer after timeout #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com>
Verify we don't receive data after a timeout. Based on reproducer for #9362 written by Matthias Kiefer <matthias.kiefer@1und1.de>. Signed-off-by: Sage Weil <sage@redhat.com>
If we cancel a read, revoke the rx buffers to avoid a use-after-free and/or other undefined badness by using user buffers that may no longer be present. Fixes: #9362 Backport: firefly, dumpling Reported-by: Matthias Kiefer <matthias.kiefer@1und1.de> Signed-off-by: Sage Weil <sage@redhat.com>
gregsfortytwo
added a commit
that referenced
this pull request
Sep 9, 2014
librados: do not write to user buffer after timeout Reviewed-by: Greg Farnum <greg@inktank.com>
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.