New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: cephfs: client: retry remount on dcache invalidation failure #24303

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
4 participants
@vshankar
Contributor

vshankar commented Sep 27, 2018

client: retry remount on dcache invalidation failure
For some (unknown) reason, there have been reports of
ceph-fuse crash due to failure is remounting at the
time of invalidating kernel dentry cache. This issue
is not also reproducible yet.

Therefore, as suggested by Patrick and Zheng, for a
temporary workaround, client would ignore the failure
as the invalidation would be retried again. There is
a max cap on the number of consecutive remount failures
after which client would abort.

Fixes: http://tracker.ceph.com/issues/35931
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit d1471f0)

 Conflicts:
	src/client/Client.cc
	src/client/Client.h
	src/common/options.cc

@vshankar vshankar added the cephfs label Sep 27, 2018

@batrick batrick changed the title from [luminous] client: retry remount on dcache invalidation failure to luminous: client: retry remount on dcache invalidation failure Sep 27, 2018

@batrick batrick added this to the luminous milestone Sep 27, 2018

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 27, 2018

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 27, 2018

@yuriw yuriw merged commit b9b68f9 into ceph:luminous Sep 28, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm changed the title from luminous: client: retry remount on dcache invalidation failure to luminous: cephfs: client: retry remount on dcache invalidation failure Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment